[PATCH] D37371: [llvm-dwp] Add command line option "-e"

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test:1
+RUN: llvm-dwp -e %p/../Inputs/dwos_list_from_exec/main -o %t
+RUN: llvm-dwarfdump %t | FileCheck %s
----------------
Should probably include a direct .dwo file in this test as well? (maybe multiple .dwo and executables, ideally - to demonstrate/test that they're both supported in plurals)


================
Comment at: tools/llvm-dwp/llvm-dwp.cpp:715
 
-  if (auto Err = write(*MS, InputFiles)) {
+  std::vector<std::string> DWOFilenames(InputFiles);
+  for (const auto &ExecFilename : ExecFilenames) {
----------------
Prefer:

  std::vector<std::string> DWOFilenames = InputFiles;

(if that compiles... ) rather than direct init.


================
Comment at: tools/llvm-dwp/llvm-dwp.cpp:718-721
+    if (!DWOs) {
+      logAllUnhandledErrors(DWOs.takeError(), errs(), "error: ");
+      return 1;
+    }
----------------
Does binutils dwp error on this, or ignore the executable?


Repository:
  rL LLVM

https://reviews.llvm.org/D37371