[llvm] r312364 - [AMDGPU] Prevent infinite recursion in DAG.computeKnownBits()

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 14:20:39 PDT 2017


On Fri, Sep 1, 2017 at 2:11 PM, Mekhanoshin, Stanislav
<Stanislav.Mekhanoshin at amd.com> wrote:
> That's a little tricky. The actual testcase is huge. I'm trying to minimize it, but actually the mistake was trivial.
>
> Stas
>

This is not ideal. In years, we'll probably forget, and no test may
result in this regression being reintroduced. In particular because
the mistake was trivial, reintroducing it is trivial as well.
I recommend following this:
https://gcc.gnu.org/wiki/A_guide_to_testcase_reduction
It takes days at times, but it should do it. (also, Mehdi wrote a
bugpoint equivalent a while ago).

Thanks,

--
Davide


More information about the llvm-commits mailing list