[PATCH] D37277: [TTI] Fix getGEPCost() for geps with a single operand

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 12:55:20 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL312357: [TTI] Fix getGEPCost() for geps with a single operand. (authored by davide).

Changed prior to commit:
  https://reviews.llvm.org/D37277?vs=113159&id=113582#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D37277

Files:
  llvm/trunk/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/trunk/test/Transforms/SimplifyCFG/gepcost.ll


Index: llvm/trunk/include/llvm/Analysis/TargetTransformInfoImpl.h
===================================================================
--- llvm/trunk/include/llvm/Analysis/TargetTransformInfoImpl.h
+++ llvm/trunk/include/llvm/Analysis/TargetTransformInfoImpl.h
@@ -675,6 +675,12 @@
 
     auto GTI = gep_type_begin(PointeeType, Operands);
     Type *TargetType = nullptr;
+
+    // Handle the case where the GEP instruction has a single operand,
+    // the basis, therefore TargetType is a nullptr.
+    if (Operands.empty())
+      return !BaseGV ? TTI::TCC_Free : TTI::TCC_Basic;
+
     for (auto I = Operands.begin(); I != Operands.end(); ++I, ++GTI) {
       TargetType = GTI.getIndexedType();
       // We assume that the cost of Scalar GEP with constant index and the
Index: llvm/trunk/test/Transforms/SimplifyCFG/gepcost.ll
===================================================================
--- llvm/trunk/test/Transforms/SimplifyCFG/gepcost.ll
+++ llvm/trunk/test/Transforms/SimplifyCFG/gepcost.ll
@@ -0,0 +1,28 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -S -simplifycfg | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "thumbv7m-none--eabi"
+
+ at glob = external unnamed_addr constant [16 x i8]
+
+define void @f() {
+; CHECK-LABEL: @f(
+; CHECK-NEXT:  entr:
+; CHECK-NEXT:    br i1 undef, label [[NEXT:%.*]], label [[EXIT:%.*]]
+; CHECK:       next:
+; CHECK-NEXT:    [[PAT:%.*]] = getelementptr [16 x i8], [16 x i8]* @glob
+; CHECK-NEXT:    br label [[EXIT]]
+; CHECK:       exit:
+; CHECK-NEXT:    ret void
+;
+entr:
+  br i1 undef, label %next, label %exit
+
+next:
+  %pat = getelementptr [16 x i8], [16 x i8]* @glob
+  br label %exit
+
+exit:
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37277.113582.patch
Type: text/x-patch
Size: 1780 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170901/50406dc1/attachment.bin>


More information about the llvm-commits mailing list