[PATCH] D37377: [ARM] Add 2-operand assembly aliases for Thumb1 ADD/SUB

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 06:46:16 PDT 2017


rengolin added a comment.

In https://reviews.llvm.org/D37377#858713, @eastig wrote:

> There might be my fault because I put my comment with the action 'Accept revision'. My understanding of the use of 'Accept revision' is that I have reviewed a patch and I accept it. Further steps, especially when to commit, should be done according to the LLVM developer policy. Maybe my understanding of this is wrong.


When you select "Accept" it means the patch can be committed without further reviews (unless you state clearly against it).

On same-company cases, due to conflict of interests as well as time-zone-wise, accepting a patch in less than 24-hours is really bad practice.

When in doubt, ask the code owner.

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D37377





More information about the llvm-commits mailing list