[PATCH] D34543: Track globals promoted to coalesced const pool entries

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

LG with the further test changes.



================
Comment at: test/CodeGen/ARM/constantpool-promote-duplicate.ll:1
+; RUN: llc -relocation-model=static -arm-promote-constant < %s | FileCheck %s
+
----------------
Please add an explicit triple.  It makes debugging things easier (when the test fails, the command itself is printed, and the host may be different).


================
Comment at: test/CodeGen/ARM/constantpool-promote-duplicate.ll:3-4
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "thumbv7m--linux-gnu"
+
----------------
I think that you can drop these.  I dont think that there is anything Linux specific about this.  I think that `thumbv7-unknown-none-eabi` is a better target.


================
Comment at: test/CodeGen/ARM/constantpool-promote-duplicate.ll:26-27
+
+attributes #0 = { nounwind  "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind }
----------------
Are the attributes really necessary?  Im pretty sure that you should be able to drop them and the annotations.


https://reviews.llvm.org/D34543