[PATCH] D37364: [DWARF] Line 0 should not have a discriminator

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 19:04:34 PDT 2017


Wouldn't this make line tables longer, as it would take extra bits in the
line table state machine to change the discriminator back to zero?

On Thu., 31 Aug. 2017, 5:46 pm Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson created this revision.
> Herald added a subscriber: JDevlieghere.
>
> We have line 0 inherit the scope of the previous non-zero line, to limit
> the size cost of the line 0 records; but that scope might have a
> discriminator attached, and a discriminator on line 0 is pointless.
>
>
> https://reviews.llvm.org/D37364
>
> Files:
>   lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>   test/CodeGen/Generic/dbg-line-0-no-discriminator.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170901/6b8fb974/attachment.html>


More information about the llvm-commits mailing list