[PATCH] D37361: Cleanup session creation code, use close() instead of rollback()

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 16:00:47 PDT 2017


MatzeB created this revision.
Herald added a subscriber: mcrosier.

session.rollback() leads to sqlalchemy producing a bunch of additional
queries to compare the objects in the session cache with the database
and rolling the objects in the cache back if necessary.  This is a lot
of unnecessary extra database traffic that we do not need there.


Repository:
  rL LLVM

https://reviews.llvm.org/D37361

Files:
  lnt/server/ui/api.py
  lnt/server/ui/decorators.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37361.113488.patch
Type: text/x-patch
Size: 5140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170831/ad22e830/attachment.bin>


More information about the llvm-commits mailing list