[PATCH] D37215: [ValueTracking] improve reverse assumption inference

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

Can you please add some test cases for this? From the description, it seems like making a variant of the first test in test/Transforms/InstCombine/assume.ll would work (with some load, etc. that `isSafeToSpeculativelyExecute` won't handle but`isGuaranteedToTransferExecutionToSuccessor`. Also, adding tests for all of the intrinsics in isAssumeLikeIntrinsic would be really helpful (because at some point we'll need to fix the semantics in `isGuaranteedToTransferExecutionToSuccessor` and we'd like not to regress).


https://reviews.llvm.org/D37215