[llvm] r312250 - [lit] Don't call realpath on the path used for test suite search

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 09:35:08 PDT 2017


Author: rnk
Date: Thu Aug 31 09:35:08 2017
New Revision: 312250

URL: http://llvm.org/viewvc/llvm-project?rev=312250&view=rev
Log:
[lit] Don't call realpath on the path used for test suite search

This preserves symlinks in paths, so that someone can symlink more tests
into a larger test suite. For example, debuginfo-tests is currently
designed to be checked out into clang/test. With this change, it can be
symlinked into place instead, which works better with the monorepo.

Modified:
    llvm/trunk/utils/lit/lit/discovery.py

Modified: llvm/trunk/utils/lit/lit/discovery.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=312250&r1=312249&r2=312250&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/discovery.py (original)
+++ llvm/trunk/utils/lit/lit/discovery.py Thu Aug 31 09:35:08 2017
@@ -57,9 +57,6 @@ def getTestSuite(item, litConfig, cache)
             cache[path] = res = search1(path)
         return res
 
-    # Canonicalize the path.
-    item = os.path.realpath(item)
-
     # Skip files and virtual components.
     components = []
     while not os.path.isdir(item):




More information about the llvm-commits mailing list