[PATCH] D37215: [ValueTracking] improve reverse assumption inference

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

This looks good, however, you need to either:

1. Don't remove isAssumeLikeIntrinsic, but instead, update isGuaranteedToTransferExecutionToSuccessor to call it.
2. Update isGuaranteedToTransferExecutionToSuccessor to have the complete list from isAssumeLikeIntrinsic.

Right now, isGuaranteedToTransferExecutionToSuccessor only checks:

  return CS.onlyReadsMemory() || CS.onlyAccessesArgMemory() ||
         match(I, m_Intrinsic<Intrinsic::assume>());


https://reviews.llvm.org/D37215