[PATCH] D36870: [libcxx] Add missing __cxa_deleted_virtual

Marshall Clow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 07:26:28 PDT 2017


mclow.lists added a comment.

In an ideal world, your example would fail to compile. However, we don't live in that world. (yet) :-(
This looks reasonable to me - but I didn't write these files - @EricWF - what do you think?

Also, from an organizational point of view, I would put these next to (and make them identical to) the entries for `___cxa_pure_virtual`


https://reviews.llvm.org/D36870





More information about the llvm-commits mailing list