[PATCH] D36813: [Coverage] Build sorted and unique segments

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 04:44:16 PDT 2017


ikudrin added a comment.

The patch doesn't apply to the current tip clearly. And after applying it manually and fix compilation errors, I have two failing tests for llvm-cov: `tools/llvm-cov/showLineExecutionCounts.cpp` and `tools/llvm-cov/threads.c`, both of which fail with "Coverage segments not unique or sorted" assertion.

I'd also prefer a set of patches where each corner case is fixed in a separate patch and which gradually lead to the final code. Of course, if it's possible. Right now it looks like just changing an old implementation to a new one, and it could be hard to investigate later and understand each particular decision in the code. What do you think?


https://reviews.llvm.org/D36813





More information about the llvm-commits mailing list