[PATCH] D37289: [X86] Speculatively load operands of select instruction

Lama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 00:03:41 PDT 2017


lsaba added a comment.

In https://reviews.llvm.org/D37289#857007, @spatel wrote:

> I didn't look at the implementation, but why is it safe to speculate loads in these tests? I can create an example where one of the pointers in the select is unmapped, so speculating that load will crash in the general case.


The implementation handles a specific case where both operands of the select are GEPs into elements of the same struct, correct me if i'm wrong but this should be safe


Repository:
  rL LLVM

https://reviews.llvm.org/D37289





More information about the llvm-commits mailing list