[PATCH] D28249: Improve scheduling with branch coalescing

[Eric Christopher via llvm-commits]

I've gone ahead and done this thusly:

Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
R lib/Target/PowerPC/PPCBranchCoalescing.cpp =>
lib/CodeGen/BranchCoalescing.cpp
M include/llvm/CodeGen/Passes.h
M include/llvm/InitializePasses.h
M lib/CodeGen/CMakeLists.txt
M lib/CodeGen/CodeGen.cpp
M lib/CodeGen/TargetPassConfig.cpp
M lib/Target/PowerPC/CMakeLists.txt
M lib/Target/PowerPC/PPC.h
M lib/Target/PowerPC/PPCTargetMachine.cpp
M test/CodeGen/PowerPC/branch_coalesce.ll
M test/CodeGen/PowerPC/select-i1-vs-i1.ll
Committed r312214

And we can revisit here tomorrow :)

On Wed, Aug 30, 2017 at 10:50 PM Eric Christopher <echristo at gmail.com>
wrote:

> On Fri, Apr 28, 2017 at 8:00 AM Lei Huang via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> lei added a comment.
>>
>> > I think most passes have a cl::opt in `TargetPassConfig.cpp` instead
>> and we don't even add the pass the pipeline if it is disable, you could
>> change to that style too to avoid people seeing the dump for a disabled
>> pass :)
>>
>> Will address this in the next patch to turn this on by default for
>> PowerPC.
>>
>
> From looking at this it's already turned on by default.
>
> Since this was unintended I'm going to go ahead and revert for now and
> then we can add it back in turned off and then turn it back on after the
> existing issues are fixed.
>
> Thanks!
>
> -eric
>
>
>> Thanks
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D28249
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170831/84f5ecad/attachment.html>