[PATCH] D37267: AMDGPU: Use set for tracked registers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 18:54:34 PDT 2017


arsenm closed this revision.
arsenm marked an inline comment as done.
arsenm added a comment.

r312206



================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:148
+    bool Inserted = Defs.insert(Def.getReg()).second;
+    (void)Inserted;
+    assert(Inserted);
----------------
javed.absar wrote:
> This doesn't seem necessary.
It prevents people from trying to make this a non-SSA pass again. I've replaced that with an isSSA assert at the beginning of the pass


https://reviews.llvm.org/D37267





More information about the llvm-commits mailing list