[PATCH] D36560: [llvm-objcopy] Add support for .dynamic, .dynsym, and .dynstr

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 16:47:37 PDT 2017


jakehehrlich added a comment.

In https://reviews.llvm.org/D36560#856314, @jhenderson wrote:

> I take it yaml2obj cannot create dynamic section/symbol table information? If it could, it would mean that no pre-built binaries would be needed for the tests.


This is correct. It might not be so hard to add though. It supports just

> A thought on the duplication of DynamicSymbolTableSection and DynamicSection: what would you think of having a shared class called something like "SectionWithStringTable", and then implementing these two section types as inheriting from that one. The only logic needed in DynamicSection/DynamicSymbolTableSection would then be the classof method.

I like that. I'll upload that in the next diff when I fix these other changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D36560





More information about the llvm-commits mailing list