[PATCH] D37309: [codeview] Generalize DIExpression parsing to handle load chains

[Bob Haarman via Phabricator via llvm-commits]

inglorion accepted this revision.
inglorion added a comment.
This revision is now accepted and ready to land.

lgtm modulo inline comment. Thanks!



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:81
+  if (Instruction.isIndirectDebugValue()) {
+    errs() << "adding load at offset for indirect value " << Offset << '\n';
+    Location.LoadChain.push_back(Offset);
----------------
Is this accidentally left in printstrumentation?


https://reviews.llvm.org/D37309