[PATCH] D37306: Add NetBSD support in test/tsan/thread_name*.cc

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 12:27:44 PDT 2017


krytarowski created this revision.
krytarowski added a project: Sanitizers.
Herald added a subscriber: kubamracek.

A snipped from the documentation of thread_setname_np(3):

NAME

  pthread_getname_np - get and set descriptive name of a thread

LIBRARY

  POSIX Threads Library (libpthread, -lpthread)

SYNOPSIS

  #include <pthread.h>
  
  int
  pthread_getname_np(pthread_t thread, char *name, size_t len);
  
  int
  pthread_setname_np(pthread_t thread, const char *name, void *arg);


Repository:
  rL LLVM

https://reviews.llvm.org/D37306

Files:
  test/tsan/thread_name.cc
  test/tsan/thread_name2.cc


Index: test/tsan/thread_name2.cc
===================================================================
--- test/tsan/thread_name2.cc
+++ test/tsan/thread_name2.cc
@@ -6,7 +6,11 @@
 
 #if defined(__FreeBSD__)
 #include <pthread_np.h>
-#define pthread_setname_np pthread_set_name_np
+#define tsan_pthread_setname_np pthread_set_name_np
+#elif defined(__NetBSD__)
+#define tsan_pthread_setname_np(a, b) pthread_setname_np((a), "%s", (void *)(b))
+#else
+#define tsan_pthread_setname_np pthread_setname_np
 #endif
 
 long long Global;
@@ -18,7 +22,7 @@
 }
 
 void *Thread2(void *x) {
-  pthread_setname_np(pthread_self(), "foobar2");
+  tsan_pthread_setname_np(pthread_self(), "foobar2");
   Global--;
   barrier_wait(&barrier);
   return 0;
@@ -29,7 +33,7 @@
   pthread_t t[2];
   pthread_create(&t[0], 0, Thread1, 0);
   pthread_create(&t[1], 0, Thread2, 0);
-  pthread_setname_np(t[0], "foobar1");
+  tsan_pthread_setname_np(t[0], "foobar1");
   barrier_wait(&barrier);
   pthread_join(t[0], NULL);
   pthread_join(t[1], NULL);
Index: test/tsan/thread_name.cc
===================================================================
--- test/tsan/thread_name.cc
+++ test/tsan/thread_name.cc
@@ -3,10 +3,14 @@
 
 #if defined(__linux__)
 #define USE_PTHREAD_SETNAME_NP __GLIBC_PREREQ(2, 12)
+#define tsan_pthread_setname_np pthread_setname_np
 #elif defined(__FreeBSD__)
 #include <pthread_np.h>
 #define USE_PTHREAD_SETNAME_NP 1
-#define pthread_setname_np pthread_set_name_np
+#define tasn_pthread_setname_np pthread_set_name_np
+#elif defined(__NetBSD__)
+#define USE_PTHREAD_SETNAME_NP 1
+#define tsan_pthread_setname_np(a, b) pthread_setname_np((a), "%s", (void *)(b))
 #else
 #define USE_PTHREAD_SETNAME_NP 0
 #endif
@@ -24,7 +28,7 @@
 
 void *Thread2(void *x) {
 #if USE_PTHREAD_SETNAME_NP
-  pthread_setname_np(pthread_self(), "Thread2");
+  tsan_pthread_setname_np(pthread_self(), "Thread2");
 #else
   AnnotateThreadName(__FILE__, __LINE__, "Thread2");
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37306.113300.patch
Type: text/x-patch
Size: 1961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170830/b28b02d9/attachment.bin>


More information about the llvm-commits mailing list