[PATCH] D37300: [WebAssembly] Add target feature for atomics

[Derek Schuff via Phabricator via llvm-commits]

dschuff marked an inline comment as done.
dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrAtomics.td:15
 
-// TODO: Implement atomic instructions.
-
-//===----------------------------------------------------------------------===//
-// Atomic fences
-//===----------------------------------------------------------------------===//
-
-// TODO: add atomic fences here...
+let Defs = [ARGUMENTS] in {
 
----------------
jgravelle-google wrote:
> Should this surround the `//==--- Atomic loads ---===//` header? Looks odd to me that it starts outside it, but ends inside it.
Should probably be after the header it since it only applies to the instruction defs, but i guess the header refers to the patterns too.


https://reviews.llvm.org/D37300