[PATCH] D37279: [codeview] make DbgVariableLocation::extractFromMachineInstruction use Expected

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:33
   if (!Instruction.isDebugValue())
-    return false;
+    return Optional<DbgVariableLocation>();
   if (!Instruction.getOperand(0).isReg())
----------------
I think the idiomatic thing to return here is `None`


https://reviews.llvm.org/D37279