[PATCH] D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D34863#856235, @kpw wrote:

> Thanks for the feedback Dean. I'm working on some FileCheck tests before I consider it ready to land, but I don't know that the implementation needs anything more.


More tests, more good! :)

> It would be useful to have a chat with you about how the stacks tool can detect sibling calls. Do we have any compiler attributes/sleds planned or implemented to track that scenario?

It's not clear whether we can actually deduce that -- what we can do is deduce when we do tail exits at least. We need to treat tail exits as an exit of the calling function, and mark it when we're building the stack to know that the duration of the caller is defined as:

  CallerStartTime - CalleeStartTime

Until we start writing out the tail exit records, we don't need to deal with these yet. But it would be good to keep in mind later.


https://reviews.llvm.org/D34863