[PATCH] D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces

[Dean Michael Berris via Phabricator via llvm-commits]

dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM for the most part.

We can iterate on this if in case we find that there's something horribly wrong.

In particular, we should look into turning parts of this into a library, in lib/XRay (and include/llvm/XRay). Especially if we're planning to use this in the conversion tool for converting to stack-based formats as well, or in the accounting tool to support stack-based accounting.

I have a slight preference to having some of this functionality in sooner and useful, rather than later.


https://reviews.llvm.org/D34863