[PATCH] D37264: [Docs] Update CodingStandards to recommend range-based for loops

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 21:23:44 PDT 2017


lattner added a comment.

FWIW, I agree with @majnemer's comments here: use of auto in those places doesn't aid in understanding/maintainability of the code, and it is important to mention that the manual loop with an explicitly evaluated end can make sense if the sequence is being mutated in the loop (but also we should recommend a comment to make that explicit!)

-Chris


https://reviews.llvm.org/D37264





More information about the llvm-commits mailing list