[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 17:51:48 PDT 2017


hans added inline comments.


================
Comment at: lld/COFF/DriverUtils.cpp:435
+  if (ExternalOutputBufferOrError) {
+    // Supress internal mt errors when manifest merge succeeds.
+    consumeError(InternalOutputBufferOrError.takeError());
----------------
Can there be other errors than not having libxml2 available? We probably don't want to suppress those.

Can't we tell by some ifdef or something when libxml2 is not available, and simply not try to use the internal tool then?


https://reviews.llvm.org/D37240





More information about the llvm-commits mailing list