[compiler-rt] r312047 - Revert "[SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer"

Matt Morehouse via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 15:05:24 PDT 2017 

1) Windows build.  Apparently the tls_model attribute doesn't work there...
2) check-asan (below)

FAIL: AddressSanitizer-x86_64-linux ::
TestCases/Linux/interface_symbols_linux.c (920 of 1294)

******************** TEST 'AddressSanitizer-x86_64-linux ::
TestCases/Linux/interface_symbols_linux.c' FAILED ********************
Script:
--
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/./bin/clang
-fsanitize=address -mno-omit-leaf-frame-pointer
-fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only
-m64 -O2 /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.c
-o /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.exe
nm -D /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.exe
| grep " [TWw] "                                            | grep -o
"\(__asan_\|__ubsan_\|__sancov_\|__sanitizer_\)[^ ]*"         | grep
-v "__sanitizer_syscall"                                         |
grep -v "__sanitizer_weak_hook"
| grep -v "__ubsan_handle_dynamic_type_cache_miss"
 | sed -e "s/__asan_version_mismatch_check_v[0-9]+/__asan_version_mismatch_check/"
  > /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.exportsgrep
-e "INTERFACE_\(WEAK_\)\?FUNCTION"
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Linux/../../../../lib/asan/asan_interface.inc

/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Linux/../../../../lib/ubsan/ubsan_interface.inc

/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Linux/../../../../lib/sanitizer_common/sanitizer_common_interface.inc
     /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Linux/../../../../lib/sanitizer_common/sanitizer_common_interface_posix.inc
  /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/asan/TestCases/Linux/../../../../lib/sanitizer_common/sanitizer_coverage_interface.inc
   | grep -v "__sanitizer_weak_hook"
    | sed -e "s/.*(//" -e "s/).*//" >
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.imports
cat /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.imports
| sort | uniq >
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.imports-sorted
cat /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.exports
| sort | uniq >
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.exports-sorted
echo
echo "=== NOTE === If you see a mismatch below, please update
sanitizer_interface.inc files."
diff /mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.imports-sorted
/mnt/b/sanitizer-buildbot1/sanitizer-x86_64-linux/build/llvm_build64/tools/clang/runtime/compiler-rt-bins/test/asan/X86_64LinuxConfig/TestCases/Linux/Output/interface_symbols_linux.c.tmp.exports-sorted
--
Exit Code: 1

Command Output (stdout):
--

=== NOTE === If you see a mismatch below, please update
sanitizer_interface.inc files.
149a150
> __sancov_lowest_stack


On Tue, Aug 29, 2017 at 3:01 PM, Kostya Serebryany <kcc at google.com> wrote:

> What broke?
>
> On Tue, Aug 29, 2017 at 2:56 PM, Matt Morehouse via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: morehouse
>> Date: Tue Aug 29 14:56:56 2017
>> New Revision: 312047
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=312047&view=rev
>> Log:
>> Revert "[SanitizeCoverage] Enable stack-depth coverage for
>> -fsanitize=fuzzer"
>>
>> This reverts r312026 due to bot breakage.
>>
>> Modified:
>>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_
>> libcdep_new.cc
>>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h
>>     compiler-rt/trunk/test/fuzzer/deep-recursion.test
>>
>> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_
>> libcdep_new.cc
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sa
>> nitizer_common/sanitizer_coverage_libcdep_new.cc?rev=312047&
>> r1=312046&r2=312047&view=diff
>> ============================================================
>> ==================
>> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc
>> (original)
>> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cc
>> Tue Aug 29 14:56:56 2017
>> @@ -211,10 +211,5 @@ SANITIZER_INTERFACE_WEAK_DEF(void, __san
>>  SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_cov_8bit_counters_init,
>> void) {}
>>  SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_cov_pcs_init, void) {}
>>  }  // extern "C"
>> -// Weak definition for code instrumented with
>> -fsanitize-coverage=stack-depth
>> -// and later linked with code containing a strong definition.
>> -// E.g., -fsanitize=fuzzer-no-link
>> -SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE
>> -SANITIZER_TLS_INITIAL_EXEC_ATTRIBUTE uptr __sancov_lowest_stack;
>>
>>  #endif  // !SANITIZER_FUCHSIA
>>
>> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_
>> defs.h
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sa
>> nitizer_common/sanitizer_internal_defs.h?rev=312047&r1=31204
>> 6&r2=312047&view=diff
>> ============================================================
>> ==================
>> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h
>> (original)
>> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h Tue
>> Aug 29 14:56:56 2017
>> @@ -35,14 +35,6 @@
>>  # define SANITIZER_WEAK_ATTRIBUTE  __attribute__((weak))
>>  #endif
>>
>> -// Mac handles TLS differently
>> -#if SANITIZER_MAC
>> -# define SANITIZER_TLS_INITIAL_EXEC_ATTRIBUTE
>> -#else
>> -# define SANITIZER_TLS_INITIAL_EXEC_ATTRIBUTE \
>> -    __attribute__((tls_model("initial-exec"))) thread_local
>> -#endif
>> -
>>  //--------------------------- WEAK FUNCTIONS
>> ---------------------------------//
>>  // When working with weak functions, to simplify the code and make it
>> more
>>  // portable, when possible define a default implementation using this
>> macro:
>>
>> Modified: compiler-rt/trunk/test/fuzzer/deep-recursion.test
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/
>> fuzzer/deep-recursion.test?rev=312047&r1=312046&r2=312047&view=diff
>> ============================================================
>> ==================
>> --- compiler-rt/trunk/test/fuzzer/deep-recursion.test (original)
>> +++ compiler-rt/trunk/test/fuzzer/deep-recursion.test Tue Aug 29
>> 14:56:56 2017
>> @@ -1,5 +1,5 @@
>>  # Test that we can find a stack overflow
>>  REQUIRES: linux
>> -RUN: %cpp_compiler %S/DeepRecursionTest.cpp -o %t
>> +RUN: %cpp_compiler -fsanitize-coverage=stack-depth
>> %S/DeepRecursionTest.cpp -o %t
>>  RUN: not %t -seed=1 -runs=100000000 2>&1 | FileCheck %s
>>  CHECK: ERROR: libFuzzer: deadly signal
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170829/d3181f44/attachment.html>

More information about the llvm-commits mailing list