[PATCH] D37123: [dwarfdump] Pretty print location expressions and location lists

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:228
+  assert(!Name.empty() && "DW_OP has no name!");
+  OS << Name.drop_front(3);
+
----------------
dblaikie wrote:
> Reckon it's worth dropping 6? (OP_ is pretty redundant)
> 
> Though as-is, or with that suggestion, it's a bit inconsistent with our other DWARF enum printing (that keeps the DW_ prefix). 
> 
> Maybe we should just drop the DW_ suffix everywhere? (I wonder about dropping DW_*_ everywhere - but maybe that'll only be done in 'brief' mode)
To be clear, my plan is to emit DW_OP_ for now. We can shorten it by default or with a flag in a follow up.


https://reviews.llvm.org/D37123