[PATCH] D36993: [llvm-dwarfdump] Print type names in DW_AT_type DIEs

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 13:02:29 PDT 2017


dblaikie added a comment.

In https://reviews.llvm.org/D36993#855144, @JDevlieghere wrote:

> In https://reviews.llvm.org/D36993#854984, @dblaikie wrote:
>
> > Where's the 'const' being printed from (couldn't spot it from a quick glance at the code) for the test cases like "const Struct"?
>
>
> The function `dumpTypeTagName` extracts the 'type name' from a tag. For the example the function dumps `DW_TAG_const_type` as `const`.


That seems a bit subtle - does that codepath trigger/do things for other tag types, or just const? Especially if it's just const, I'd probably handle const where reference, array, pointer, etc, are handled. Seems clearer.


Repository:
  rL LLVM

https://reviews.llvm.org/D36993





More information about the llvm-commits mailing list