[PATCH] D37251: [X86] Add a pass to convert instruction chains between domains

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added inline comments.


================
Comment at: lib/Target/X86/X86DomainReassignment.cpp:201
+
+    for (auto &MO : MI->operands()) {
+      if (TargetRegisterInfo::isPhysicalRegister(MO.getReg()))
----------------
The COPY has only 2 operands, right?
Why do you need so complex computations here?


================
Comment at: lib/Target/X86/X86DomainReassignment.cpp:473
+
+void Closure::buildClosure(unsigned E) {
+  addToWorklist(E);
----------------
Please replace E with a meaningful variable name.


================
Comment at: lib/Target/X86/X86DomainReassignment.cpp:494
+    for (int OpIdx = 0; OpIdx < OpEnd; ++OpIdx) {
+      if (OpIdx == MemOp) {
+        // skip address calculation.
----------------
I think that you can iterate to MemOp. After the MemOp may be only immediate.


https://reviews.llvm.org/D37251