[PATCH] D37153: [LoopUnroll] Properly update loop structure in case of successful peeling

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: llvm/trunk/test/Transforms/LoopUnroll/pr33437.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -loop-unroll %s -S | FileCheck %s
+
----------------
davide wrote:
> mzolotukhin wrote:
> > Won't `opt %s -S` overwrite the input file with the output?
> No, I don't think so.
> If it does, then I'll need to change the other hundreds of tests I've written :)
The main reason to avoid `opt -S %s` (and prefer `opt -S < %s`) is that `opt -S %s` prints out the file name which can cause mismatches (tests can pass or fail spuriously).  I don't know if any OS allows this, but e.g. you could have `@tinky(` in the file path somewhere and the `CHECK-NEXT` on line 8 would fail.


Repository:
  rL LLVM

https://reviews.llvm.org/D37153