[PATCH] D37193: Add NetBSD specific version of sanitizer_platform_limits_posix

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 12:52:06 PDT 2017


kcc added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:4117
   if (res >= 0) {
+#if SANITIZER_NETBSD
+    unsigned sz = struct_shminfo_sz;
----------------
krytarowski wrote:
> kcc wrote:
> > can you use if (SANITIZER_NETBSD) here? 
> No, as variables like `shmctl_shm_info` are absent.
Please find a way to avoid this #if. 


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:1
+//===-- sanitizer_platform_limits_posix.cc --------------------------------===//
+//
----------------
fix the comment. 


Repository:
  rL LLVM

https://reviews.llvm.org/D37193





More information about the llvm-commits mailing list