[PATCH] D37153: [LoopUnroll] Properly update loop structure in case of successful peeling

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 11:37:00 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D37153#854336, @mzolotukhin wrote:

> Hi,
>
> The change looks good to me, but I'd like to see a more simplified test. We probably don't need 90% of its instructions, and also it doesn't need to be SystemZ-specific.
>
> Michael


FWIW, this only triggers with SystemZ as triple (probably because it sets peeling parameters differently?). It might apply to other triples as well, but it doesn't seem to crash on Linux x86-64 (or FreeBSD x86-64), which are the only two other triples I have available.
I concur with you this is a more general problem, although I can't trigger this in a different way :)

On your other point, let me try to reduce this further :)


https://reviews.llvm.org/D37153





More information about the llvm-commits mailing list