[PATCH] D37164: [ARM] Fix bug in ARMLoadStoreOptimizer when kill flags are missing.

Geoff Berry via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 07:40:26 PDT 2017


gberry added a comment.

In https://reviews.llvm.org/D37164#853040, @efriedma wrote:

> If I understand correctly, the original code was checking for the kill flags just to short-circuit the if statement more quickly?


That's what it looks like to me: an attempt to reduce the calls to regsOverlap().  Or at least that would make sense for 'BaseKill'.  Checking 'OffKill' I don't get unless 'Base' and 'Off' are somehow known to be related?


https://reviews.llvm.org/D37164





More information about the llvm-commits mailing list