[PATCH] D37194: [Sparc][NFC] Clean up SelectCC lowering

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 27 07:26:31 PDT 2017


asb created this revision.
Herald added subscribers: fedor.sergeev, kristof.beyls, arichardson, sdardis, aemerson.

The ARM, BPF, MSP430, Sparc and Mips backends all use a similar code sequence for lowering SelectCC. As pointed out by @reames in https://reviews.llvm.org/D29937, this code isn't particularly clear and in most of these backends doesn't actually match the comments. This patch makes the code sequence clearer for the Sparc backend through better variable naming and more accurate comments (e.g. we are inserting triangle control flow, _not_ diamond). There is no functional change.


https://reviews.llvm.org/D37194

Files:
  lib/Target/Sparc/SparcISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37194.112826.patch
Type: text/x-patch
Size: 3657 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170827/9c7fb485/attachment.bin>


More information about the llvm-commits mailing list