[PATCH] D37118: [ARM] Tidy-up ARMAsmParser. NFC.

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 27 06:03:06 PDT 2017


javed.absar added inline comments.


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:268
+  // Return the low-subreg of a given Q register.
+  unsigned getDRegFromQReg(unsigned QReg) {
+    return MRI->getSubReg(QReg, ARM::dsub_0);
----------------
fhahn wrote:
> this could be a const function I think?
Yes indeed. Will do so before committing


https://reviews.llvm.org/D37118





More information about the llvm-commits mailing list