[PATCH] D36841: [SimplifyCFG] Fix for PR34219: Preserve alignment after merging conditional stores.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 12:44:14 PDT 2017


efriedma added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2972
+  if (unsigned Alignment = PStore->getAlignment())
+    SI->setAlignment(Alignment);
 
----------------
ABataev wrote:
> efriedma wrote:
> > What happens if PStore and QStore have different alignment?
> Generally speaking, they must be the same.
I don't see any code to ensure they are the same.  (Or do you mean we shouldn't do this transform if the alignment is different?)


https://reviews.llvm.org/D36841





More information about the llvm-commits mailing list