[PATCH] D6379: Only warn about DWARF2 supporting one section per compilation unit for code sections

Dimitry Andric via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 12:25:30 PDT 2017


dim added a comment.

In https://reviews.llvm.org/D6379#95991, @dblaikie wrote:

> Should we add that filter elsewhere rather than here? (eg: we shouldn't be adding such non-text sections into the Sections map if they're not part of teh DWARF anyway, right?)


Maybe, but I don't know the code around this part well enough to make that fix.  The above fix is a small one-liner, and solves the problem in a nicely minimal fashion.

> & this could use a test case as well.

I'll add one.


https://reviews.llvm.org/D6379





More information about the llvm-commits mailing list