[PATCH] D36963: Use sorting instead of a lot of stable_partitions for `ICF::segregate` function

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D36963#852284, @alex.telishev wrote:

> How exactly have you tested for non-determinism? I've tried to do that by comparing output binaries for my project, but they were different every time even before this patch. Could you try testing for determinism with and without this patch?


Are you testing with /DEBUG or without?  With /DEBUG we have to generate a random GUID into the executable for the PDB when doing a fresh build, but without /DEBUG I believe they should still be identical.  Eventually we will need a way to create reproducible builds even with /DEBUG (for example by putting a placeholder GUID like {00000000-0000-0000-0000-000000000000} behind an option).

Try without /DEBUG and see.


https://reviews.llvm.org/D36963