[PATCH] D36788: The issues with X86 prefixes

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 02:25:26 PDT 2017


avt77 added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:993
     }
+  } else if (insn->mode == MODE_64BIT && !insn->mandatory_prefix) {
+    // If we don't have mandatory prefix we should use "standard" prefixes here
----------------
craig.topper wrote:
> Is this 64-bit mode checks till needed?
In fact we need 

... else if (insn->mode != MODE_16BIT ....

I'll do it. Tnx.


https://reviews.llvm.org/D36788





More information about the llvm-commits mailing list