[PATCH] D37095: [ADCE] Follow inlinedAt when determining if a DbgInfoIntrinsic is dead

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 01:26:21 PDT 2017


uabelho abandoned this revision.
uabelho added a comment.

In https://reviews.llvm.org/D37095#851557, @aprantl wrote:

> I don't understand the example in the testcase.  There is no instruction belonging to f1, so the debugger can never stop at f1 to print the value of the anonymous variable !5.


Very good point. Thanks!

We did this change (for some now unknown reason unfortunately) locally in our tree a year and a half ago and I thought I would try to
upstream it, but as you're saying, it's very questionable what it's actually good for.

If I make f1 more complicated (e.g. adding "i = i + 1;" to it), both that instruction as well as a dbg.value survives in f2.

So instead of pushing this, I'll remove our local change and drop the patch. If it's really needed I suppose it will pop up again
and I can come back with a proper patch.

Thanks and sorry for wasting you time.


https://reviews.llvm.org/D37095





More information about the llvm-commits mailing list