[PATCH] D36986: [ELF] Handle assignments outside SECTIONS command separately

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 01:16:50 PDT 2017


phosek added a comment.

In https://reviews.llvm.org/D36986#852125, @ruiu wrote:

> Ah, you are right that reordering elements won't fix the problem. The idea to have two separate lists sounds like a good idea.


I tried to separate the lists, but that also turned out to be tricky because of ordering, e.g. in `foo = 0x1 SECTIONS { bar = foo } baz = bar` the symbols outside and inside `SECTIONS` have to be added to the symbol table in that particular order which is difficult when they're in separate lists. Given that, I think the current solution albeit not pretty is still the simplest one.


Repository:
  rL LLVM

https://reviews.llvm.org/D36986





More information about the llvm-commits mailing list