[PATCH] D36810: Minimal runtime for UBSan.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 15:48:40 PDT 2017


eugenis added inline comments.


================
Comment at: compiler-rt/lib/ubsan_minimal/CMakeLists.txt:63
+  endif()
+endif()
----------------
kubamracek wrote:
> Not an objection for this particular patch, but I noticed the amount of CMake boilerplate code necessary for the bring-up of a new sanitizer tool is very high (and this is even without macOS support).  Is there a way to refactor and reduce that?
I've removed some of the code that is unnecessary for this runtime.  I'm not sure about factoring large parts of it out. It feels like there are a lot of things in this code that might be different in one sanitizer or the other.


https://reviews.llvm.org/D36810





More information about the llvm-commits mailing list