[PATCH] D33880: COFF: Introduce LD shim around LINK

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 12:35:27 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D33880#851739, @ruiu wrote:

> > He actually already adds one test case within test/COFF/out.test - linking and checking an implicitly named output a.exe. I guess you at least want that test split out to a separate file in a separate directory then?
>
> Yes, I think we want to have a separate directory under test as we have one at the top level directory.
>
> Also, the test seems too simple. I want to see a test file that tests -o, -entry, -subs, -shared, -outlib, -stack and __image_base__.


Ok, makes sense.

Although I think we should just drop handling of `-shared` from this patch and focus on getting the rest of it OK'd. Actually producing working DLLs is incomplete in this patch anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D33880





More information about the llvm-commits mailing list