[test-suite] r311689 - [test-suite] Fix uninitialized memory use in PathFinder

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 12:09:29 PDT 2017


Author: hfinkel
Date: Thu Aug 24 12:09:29 2017
New Revision: 311689

URL: http://llvm.org/viewvc/llvm-project?rev=311689&view=rev
Log:
[test-suite] Fix uninitialized memory use in PathFinder

We need to use the allocation function here with actually initializes the
structure.

Thanks to Adrian Prantl for pointing out the problem (because it was causing
non-deterministic buildbot failures).

Modified:
    test-suite/trunk/MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/configuration.c

Modified: test-suite/trunk/MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/configuration.c
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/configuration.c?rev=311689&r1=311688&r2=311689&view=diff
==============================================================================
--- test-suite/trunk/MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/configuration.c (original)
+++ test-suite/trunk/MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/configuration.c Thu Aug 24 12:09:29 2017
@@ -54,7 +54,7 @@
  Configuration* Configuration_new()
  {
     Configuration *new = malloc(sizeof(Configuration));
-    SearchOptions *options = malloc(sizeof(SearchOptions));
+    SearchOptions *options = SearchOptions_new();
     if ( !new || !options )
     {
         if ( new ) free(new);




More information about the llvm-commits mailing list