[PATCH] D36993: [llvm-dwarfdump] Print type names in DW_AT_type DIEs

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFDie.cpp:84
 
+static void dumpTagName(raw_ostream &OS, dwarf::Tag T) {
+  StringRef TagStr = TagString(T);
----------------
This function name isn't descriptive enough; I had to read the code to understand what it was doing.  Maybe `dumpTypeTagName` or something like that.


================
Comment at: lib/DebugInfo/DWARF/DWARFDie.cpp:130
+    break;
+  default:
+    break;
----------------
Missing rvalue_reference_type.


Repository:
  rL LLVM

https://reviews.llvm.org/D36993