[PATCH] D33880: COFF: Introduce LD shim around LINK

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 10:02:50 PDT 2017


martell added inline comments.


================
Comment at: MinGW/Driver.cpp:190
+  std::vector<const char *> LinkVec(LinkArgs.size(), nullptr);
+  for (std::vector<std::string>::size_type I = 0; I < LinkArgs.size(); ++I) {
+    LinkVec[I] = LinkArgs[I].c_str();
----------------
I could probably use `auto` here instead of `std::vector<std::string>::size_type`?
Other then that I think I have addressed all the comments


Repository:
  rL LLVM

https://reviews.llvm.org/D33880





More information about the llvm-commits mailing list