[PATCH] D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm

Wed Aug 23 09:16:05 PDT 2017

I've managed to get at the logs using my phone and I don't think the problem is my patch. It looks like a recurring problem we've been having with some of the windows bots where changing tablegen but not the tablegen inputs doesn't cause the various .inc files to be re-generated. I think it just needs a clean build.

> On 23 Aug 2017, at 16:41, Daniel Sanders via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Thanks (especially for including the error). I've been trying to get to lab.llvm.org:8011 <http://lab.llvm.org:8011/> to find out if it was my commit or not but the connection just terminates unexpectedly. The others emails I received at the same time weren't related to GlobalISel so I was hoping this one was the same issue. I'll take a look.
> 
>> On 23 Aug 2017, at 16:25, Victor Leschuk <vleschuk at accesssoftek.com <mailto:vleschuk at accesssoftek.com>> wrote:
>> 
>> Hello Daniel,
>> 
>> I had to revert your commit as it broke Windows build. Please see: 
>> 
>> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/4394 <http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/4394>
>> FAILED: lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64InstructionSelector.cpp.obj 
>> C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe  /nologo /TP -DEXPENSIVE_CHECKS -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_DEBUG -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Target\AArch64 -IC:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\lib\Target\AArch64 -Iinclude -IC:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\include /DWIN32 /D_WINDOWS   /WX /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /MDd /Zi /Ob0 /Od /RTC1    /EHs-c- /GR- /showIncludes /Folib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\AArch64InstructionSelector.cpp.obj /Fdlib\Target\AArch64\CMakeFiles\LLVMAArch64CodeGen.dir\LLVMAArch64CodeGen.pdb /FS -c C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\lib\Target\AArch64\AArch64InstructionSelector.cpp
>> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\lib\Target\AArch64\AArch64InstructionSelector.cpp(103): error C2664: 'llvm::InstructionSelector::MatcherInfoTy<`anonymous-namespace'::PredicateBitset,`anonymous-namespace'::AArch64InstructionSelector::ComplexMatcherMemFn>::MatcherInfoTy(llvm::InstructionSelector::MatcherInfoTy<`anonymous-namespace'::PredicateBitset,`anonymous-namespace'::AArch64InstructionSelector::ComplexMatcherMemFn> &&)': cannot convert argument 1 from 'initializer list' to 'const llvm::InstructionSelector::MatcherInfoTy<`anonymous-namespace'::PredicateBitset,`anonymous-namespace'::AArch64InstructionSelector::ComplexMatcherMemFn> &'
>> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\lib\Target\AArch64\AArch64InstructionSelector.cpp(103): note: Reason: cannot convert from 'initializer list' to 'const llvm::InstructionSelector::MatcherInfoTy<`anonymous-namespace'::PredicateBitset,`anonymous-namespace'::AArch64InstructionSelector::ComplexMatcherMemFn>'
>> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\lib\Target\AArch64\AArch64InstructionSelector.cpp(103): note: Invalid aggregate initialization
>> 
>> On 07/31/2017 03:31 PM, Daniel Sanders via Phabricator via llvm-commits wrote:
>>> dsanders created this revision.
>>> Herald added subscribers: igorb, javed.absar, kristof.beyls.
>>> 
>>> Depends on https://reviews.llvm.org/D36085 <https://reviews.llvm.org/D36085>
>>> 
>>> 
>>> https://reviews.llvm.org/D36086 <https://reviews.llvm.org/D36086>
>>> 
>>> Files:
>>>   include/llvm/CodeGen/GlobalISel/InstructionSelector.h
>>>   include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h
>>>   test/CodeGen/AArch64/GlobalISel/select-neon-vcvtfxu2fp.mir
>>>   test/TableGen/GlobalISelEmitter.td
>>>   utils/TableGen/GlobalISelEmitter.cpp
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>> 
>> -- 
>> Best Regards,
>> 
>> Victor Leschuk | Software Engineer |Access Softek
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170823/5de2e4f6/attachment-0001.html>