[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 08:24:05 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:283
+  if (ErrorCount)
+    error(">>> location:" + getCurrentLocation());
 }
----------------
Do not call `error` twice for one error message.

Okay, so I think we need some better infrastructure for diagnostics if we really want to improve linker script diagnostics. That's not that high priority, but it is worth to try. I'll try to create one. Until then, please hold on with and other changes for diagnostics.


https://reviews.llvm.org/D35945





More information about the llvm-commits mailing list