[PATCH] D23568: [RISCV 10/10] Add common fixups and relocations

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 06:48:34 PDT 2017


asb updated this revision to Diff 112355.
asb added a comment.

Just spotted a minor issue. RISCVMCExpr::getVariantKindForName would be better returning `VK_RISCV_Invalid` if the name is unrecognised rather htna `VK_RISCV_None`. Updated diff fixes this.


https://reviews.llvm.org/D23568

Files:
  lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  lib/Target/RISCV/MCTargetDesc/CMakeLists.txt
  lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
  lib/Target/RISCV/MCTargetDesc/RISCVELFObjectWriter.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVFixupKinds.h
  lib/Target/RISCV/MCTargetDesc/RISCVMCCodeEmitter.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.cpp
  lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.h
  lib/Target/RISCV/RISCVInstrFormats.td
  lib/Target/RISCV/RISCVInstrInfo.td
  test/MC/RISCV/fixups-diagnostics.s
  test/MC/RISCV/fixups.s
  test/MC/RISCV/hilo-constaddr.s
  test/MC/RISCV/relocations.s
  test/MC/RISCV/rv32i-invalid.s
  test/MC/RISCV/rv32i-valid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23568.112355.patch
Type: text/x-patch
Size: 50209 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170823/1d070cea/attachment.bin>


More information about the llvm-commits mailing list