[PATCH] D23568: [RISCV 10/10] Add common fixups and relocations

[Alex Bradbury via Phabricator via llvm-commits]

asb marked 4 inline comments as done.
asb added a comment.

Thanks for the comments Dylan. Playing around with this, I've noticed that the MC assembler is too accepting of some inputs (e.g. accepting `addi a1, a2, %hi(foo)` where gas would reject it). I'm fixing this and expanding tests now, which will change many of the `isFoo` functions anyway. I'll watch for the else after return thing. I personally don't find that guideline very compelling for `else if` cases where removing the else fails to reduce indentation, but I shall of course conform with LLVM norms :)

The last patch update didn't have full context included - sorry for that.


https://reviews.llvm.org/D23568