[PATCH] D37030: Fix ARMv4 support

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 03:16:49 PDT 2017


fhahn added a subscriber: rengolin.
fhahn added a comment.

I think this change makes sense. Looping in @rengolin as he may have some more insight



================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:1912
     if (Use.isKill()) {
+      assert(STI->hasV4TOps());
       BuildMI(MBB, MBBI, MBBI->getDebugLoc(), TII->get(ARM::tBX))
----------------
I'm not sure if this assertion is really needed here. If the block does not already contain a BX instruction, we exit early.


Repository:
  rL LLVM

https://reviews.llvm.org/D37030





More information about the llvm-commits mailing list